download only from safe sources

Woko · Post by **Woko** » 2004-06-25 09:55

It would be great to be able to download only from safe (* starred) sources and maybe later from TTH searches only. In my opition the starred transfers are much less corrupted than normal so i would like to use only them, and now i have to remove user from queue every time i see an unstarred transfer. I think many ppl would appreciate this feature.
Great work anyway.
Vojtech Kolacek

Todi · Post by **Todi** » 2004-06-25 10:15

Well, yes, that's the whole point of "starred transfers".

However, you never know if one will be until you start downloading.. so it's impossible to detect in advance.

Woko · Post by **Woko** » 2004-06-25 11:02

Todi wrote:Well, yes, that's the whole point of "starred transfers". However, you never know if one will be until you start downloading.. so it's impossible to detect in advance.

Yes, you probably cant be sure, but 1) u can check the tag of the person ure downloading from for a version of DC++ 2) when tryng to establish connection u certainly know if the transfer is starred or not, so instead of starting unstarred transfer u can just abort the connection and remove user from queue. Havent seen the sources, but i guess its sumthing like that.

Todi · Post by **Todi** » 2004-06-25 11:16

1) Sure, you can look if his tag says 0.400 or higher, but that's ugly, and not reliable at all.
2) True, but if i'm not mistaken you need a slot to detect that, and that would make it somewhat ugly too. But ok, it should work. Write a patch

Woko · Post by **Woko** » 2004-06-25 13:17

Todi wrote:1) Sure, you can look if his tag says 0.400 or higher, but that's ugly, and not reliable at all.
2) True, but if i'm not mistaken you need a slot to detect that, and that would make it somewhat ugly too. But ok, it should work. Write a patch

Not mentioning 1 which is unpractical, I agree that 2 is not very ellegant, but i only get about 1 unstarred download in 20 since most people have up-to-date DC++. So for that 1/20 i have to go through all downloaded eps (2GB/day) and redownload corrupted. This feature would help me a lot till everyone has an uptodate client. It i had known how to write a patch (and had dotnet, of course), i would have done so long time ago :twisted:

PseudonympH · Post by **PseudonympH** » 2004-06-25 14:00

Todi wrote:2) True, but if i'm not mistaken you need a slot to detect that, and that would make it somewhat ugly too. But ok, it should work. Write a patch

Wouldn't you just have to check their supports for GetZBlock, and disconnect if it's not there? That comes before any get commands....

Gasman1015 · Post by **Gasman1015** » 2004-06-25 18:02

ChangeLog 0.402

* Removed GetTestZBlock (no more safe/compressed transfers from old clients)

Not that it is relevant.

Sedulus · Post by **Sedulus** » 2004-06-25 23:43

woko, if you get that many corrupted files, you should really look at your own hardware and software (running an old version of ZoneAlarm perhaps?).

Todi · Post by **Todi** » 2004-06-26 11:34

Right, you could detect by $Supports.. that's a pretty clean solution =)

Post by **GargoyleMT** » 2004-06-26 13:40

Transfers only from compressed sources makes some sense (not as much as only transfers-with-a-tth though, as that's a much better way of checking file integrity). However, there's at least one down side: You can queue files from search or file lists that have no users with safe/compressed transfers enabled. So, you could (essentially) orphan your downloads.

PseudonympH · Post by **PseudonympH** » 2004-06-26 20:18

So then you turn the option off and re-add all the removed sources.

joakim_tosteberg · Post by **joakim_tosteberg** » 2004-06-27 06:11

Or perhaps you should have another item i n the right click list in the download queue so you can allw/disallow on a er file basis?

Post by **GargoyleMT** » 2004-06-27 14:25

Not really necessary, as 0.402 is out and it will verify file integrity...

download only from safe sources

download only from safe sources

Who is online