Adding of all search hits as alternative download locations

[JCTor]

I have activated the feature "Automatically search for alternative download locations" in my DC++ (0.24).

Right now, when I issue a search that generates hits for any of the files that are in my download queue, only some of them are added as alternative sources in the download queue, and this adding is seemingly arbitrary?!

For example, if I have the following files in my download queue:

someapp_01.zip
someapp_02.zip
someapp_03.zip
someapp_04.zip
someapp_05.zip
someapp_06.zip

And then I issue a search for for example "someapp_0". Let's say I then find 5 people in the search that have all these files (and they show up in the search result window too, so it's not due to the limiting of search hits from individual users).

Then I would like that _all_ these users should automatically be added as alternative sources for _all_ these files. Right now they only seem to be added to one file per user at the time, and then I have to issue the same search again and again (when the current download from these users are complete) to make it start downloading another file from these users again.

I think this is highly inefficient, and I cannot understand why it is like this? Wouldn't it be great to make it so that all hits in a manual search that are already in the download queue are added as alternative sources? It would be such an efficiency improvement, don't you agree?

[GargoyleMT]

Can you scroll over in the Search dialog and make sure that the hits that are not being added have the same file length as the target (and as the ones that were added as sources during that search)? Maybe they're not being added because they're not the same file.

[JCTor]

No, it is the exact same files. If I add them "manually" as a new source, it works like a charm.

[GargoyleMT]

Did you do a manual "Search For Alternates", or a regular search? There's a bug report (in the tracker on sourceforge, down at the moment), I believe, that says that searching for certain substrings of a file doesn't always return that file.

So if you're doing a normal search and finding results that aren't matched and added as alternate sources, it might be a different face of the same problem. Whereas if you're doing a "Search for Alternates" and it's not adding, it might be something new.

Not entirely sure on either count.

[JCTor]

I'm doing a normal search (since the "search for alternates" feature only works on single files in the download queue). And the files are indeed returned in the search result listing, they are just not all added as new sources (as mentioned above, only one, or possibly a couple of files are added as alternative sources and started downloaded).

[GargoyleMT]

Next time it happens, can you get a screenshot of the listing and tell me which files are matched and not matched? (PM me and I'll give you my email address, so you don't have to post anything publically.)

I get the feeling that the files that are not added don't contain exactly the same strings as the ones that you're downloading. Of course we can tell that they belong, but DC++ is pretty simple about such things. Perhaps something can be done to smarten it up, though. This theory doesn't work if you can search using the same strings, get the same results, and have different search items added as alternates each time.

[JCTor]

Ok, thanks, I will try to reproduce it once again and send you screenshots, just like you instruct.

Thanks!